lkml.org 
[lkml]   [2014]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 194/203] rbd: Fix error recovery in rbd_obj_read_sync()
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jan Kara <jack@suse.cz>

    commit a8d4205623ae965e36c68629db306ca0695a2771 upstream.

    When we fail to allocate page vector in rbd_obj_read_sync() we just
    basically ignore the problem and continue which will result in an oops
    later. Fix the problem by returning proper error.

    CC: Yehuda Sadeh <yehuda@inktank.com>
    CC: Sage Weil <sage@inktank.com>
    CC: ceph-devel@vger.kernel.org
    Coverity-id: 1226882
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Ilya Dryomov <idryomov@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/block/rbd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/block/rbd.c
    +++ b/drivers/block/rbd.c
    @@ -3217,7 +3217,7 @@ static int rbd_obj_read_sync(struct rbd_
    page_count = (u32) calc_pages_for(offset, length);
    pages = ceph_alloc_page_vector(page_count, GFP_KERNEL);
    if (IS_ERR(pages))
    - ret = PTR_ERR(pages);
    + return PTR_ERR(pages);

    ret = -ENOMEM;
    obj_request = rbd_obj_request_create(object_name, offset, length,



    \
     
     \ /
      Last update: 2014-11-12 05:01    [W:6.670 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site