Messages in this thread | | | Date | Wed, 12 Nov 2014 12:16:05 +0900 | From | Yasuaki Ishimatsu <> | Subject | Re: [PATCH] memory-hotplug: remove redundant call of page_to_pfn |
| |
(2014/11/11 18:13), Zhang Zhen wrote: > The start_pfn can be obtained directly by > phys_index << PFN_SECTION_SHIFT. > > Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> > ---
The patch looks good to me but I want you to write a purpose of the patch to the description for other reviewer.
Thanks, Yasuaki Ishimatsu
> drivers/base/memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 7c5d871..85be040 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -228,8 +228,8 @@ memory_block_action(unsigned long phys_index, unsigned long action, int online_t > struct page *first_page; > int ret; > > - first_page = pfn_to_page(phys_index << PFN_SECTION_SHIFT); > - start_pfn = page_to_pfn(first_page); > + start_pfn = phys_index << PFN_SECTION_SHIFT; > + first_page = pfn_to_page(start_pfn); > > switch (action) { > case MEM_ONLINE: >
| |