Messages in this thread | | | Date | Tue, 11 Nov 2014 20:01:49 -0600 | From | German Rivera <> | Subject | Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver |
| |
On 11/06/2014 07:50 AM, Alexander Graf wrote: > [cut] >> +++ b/drivers/bus/fsl-mc/Kconfig >> @@ -0,0 +1,13 @@ >> +# >> +# Freescale Management Complex (MC) bus drivers >> +# >> +# Copyright (C) 2014 Freescale Semiconductor, Inc. >> +# >> +# This file is released under the GPLv2 >> +# >> + >> +config FSL_MC_BUS >> + tristate "Freescale Management Complex (MC) bus driver" >> + help >> + Driver to enable the bus infrastructure for the Freescale >> + QorIQ Management Complex. > > Isn't this missing some scope limitations? Should we really have the > driver enabled on x86 for example? > I will add depends on OF && ARM64
> I would also make this slightly more verbose. People don't necessarily > know what the QorIQ Management Complex is. Give people some idea what > they're dealing with and preferably tell them hints that guide them from > "SoC name" to "should I enable this option?". > > Also, usually the help text gives some guidance on what to do with the > option if you're not sure. In this case, I would say advise the user to > say N. > Will do.
> > Alex >
| |