Messages in this thread | | | Date | Mon, 10 Nov 2014 15:43:48 -0700 | From | Jens Axboe <> | Subject | Re: [PATCH] scsi: Fix more error handling in SCSI_IOCTL_SEND_COMMAND |
| |
On 2014-11-10 15:40, Tony Battersby wrote: > Fix an error path in SCSI_IOCTL_SEND_COMMAND that calls > blk_put_request(rq) on an invalid IS_ERR(rq) pointer. > > Fixes: a492f075450f ("block,scsi: fixup blk_get_request dead queue scenarios") > Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Thanks, good catch. Might be an idea to have blk_put_request() do warn-and-return check on error pointers being passed in, just in case.
-- Jens Axboe
| |