lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/5] lib: lockless generic and arch independent page table (gpt) v2.
From
On Mon, Nov 10, 2014 at 1:35 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Or do you actually have a setup where actual non-CPU hardware actually
> walks the page tables you create and call "page tables"?

So just to clarify: I haven't looked at all your follow-up patches at
all, although I've seen the overviews in earlier versions. When trying
to read through the latest version, I got stuck on this one, and felt
it was crazy.

But maybe I'm misreading it and it actually has good reasons for it.
But just from the details I look at, some of it looks too incestuous
with the system (the split PTL lock use), other parts look really
really odd (like the 64-bit shift counts), and some of it looks just
plain buggy (the bitops for synchronization). And none of it is all
that easy to actually read.

Linus


\
 
 \ /
  Last update: 2014-11-10 23:21    [W:0.122 / U:1.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site