lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL for v3.18-rc1] media updates
Em Mon, 10 Nov 2014 21:45:56 +0100
Paul Bolle <pebolle@tiscali.nl> escreveu:

> Hi Mauro,
>
> On Mon, 2014-10-20 at 10:31 +0200, Paul Bolle wrote:
> > This became commit 38a073116525 ("[media] omap: be sure that MMU is
> > there for COMPILE_TEST").
> >
> > As I reported in
> > http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/82299
> > it adds an (optional) test for a Kconfig symbol HAS_MMU. There's no
> > such symbol. So that test will always fail. Did you perhaps mean
> > simply "MMU"?
>
> This typo is still present in both next-20141110 and v3.18-rc4. And I've
> first reported it nearly two months ago. I see two fixes:
> 1) s/HAS_MMU/MMU/
> 2) s/ || (COMPILE_TEST && HAS_MMU)//
>
> Which would you prefer?

Hmm... Probably patchwork didn't get your patch.

IMHO, the best would be:

depends on HAS_MMU
depends on ARCH_OMAP2 || ARCH_OMAP3 || COMPILE_TEST

Regards,
Mauro


\
 
 \ /
  Last update: 2014-11-10 22:21    [W:0.085 / U:4.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site