Messages in this thread Patch in this message | | | Date | Mon, 10 Nov 2014 20:00:05 +0000 | From | Liviu Dudau <> | Subject | Re: [PATCH v2 2/2] arm64: Add Juno SoC device tree. |
| |
On Mon, Nov 10, 2014 at 07:05:42PM +0000, Andreas Färber wrote: > Hi, > > Am 10.11.2014 um 12:27 schrieb Liviu Dudau: > > diff --git a/arch/arm64/boot/dts/juno.dts b/arch/arm64/boot/dts/juno.dts > > new file mode 100644 > > index 0000000..7f998de > > --- /dev/null > > +++ b/arch/arm64/boot/dts/juno.dts > > @@ -0,0 +1,374 @@ > > +/* > > + * ARM Ltd. Juno Plaform > "Platform" > > > + * > > Shouldn't this mention a license, ideally dual-licensed?
Hi Andreas,
TBH I wasn't sure a license was needed. Most (all?) of ARM's DT files don't seem to carry a license, but I will add the appropriate license. And yes, it is dual-licensed (GPLv2 or BSD)
> > > + */ > > + > > +/dts-v1/; > > + > > +#include <dt-bindings/interrupt-controller/arm-gic.h> > > + > > +/ { > > + model = "Juno"; > > + compatible = "arm,juno", "arm,vexpress"; > > + interrupt-parent = <&gic>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + aliases { > > + serial0 = &soc_uart0; > > + }; > > + > > + cpus { > > + #address-cells = <2>; > > + #size-cells = <0>; > > + > > + A53_0:cpu@100 { > [snip] > > Can you please add a space after colon, like you did for non-CPU nodes?
Sure, will do.
Best regards, Liviu
> > Regards, > Andreas > > -- > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg >
-- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |