Messages in this thread | | | Subject | Re: [Xen-devel] BUG in xennet_make_frags with paged skb data | From | Eric Dumazet <> | Date | Mon, 10 Nov 2014 09:02:35 -0800 |
| |
On Mon, 2014-11-10 at 16:42 +0000, David Vrabel wrote: > On 10/11/14 16:39, Zoltan Kiss wrote: > > > > The BUG_ON suggested by Stefan would be still reasonable: > > > > BUG_ON(((page-compound_head(page))*PAGE_SIZE)+offset+len > > > PAGE_SIZE<<compound_order(compound_head(page))); > > Well, it wouldn't trigger but I don't think it is useful any more.
Right.
This BUG_ON() does not make sense (its current implementation is assuming a very precise layout anyway)
If we really wanted some debugging, we would need something more generic and done in core networking stack, not in a particular driver.
| |