lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/18] perf tools: Make vmlinux short name more like kallsyms short name
On Mon, Nov 10, 2014 at 03:13:46PM +0900, Namhyung Kim wrote:

SNIP

> >> + dso__set_short_name(dso, "[kernel.vmlinux]", false);
> >> +
> >
> > heya,
> > I've got attached segfault in perf script because of this,
> > if I revert it's ok..
>
> Oops, sorry. It seems somehow to fail to find a matching kernel dso
> from the build-id table.. anyway we need to access 'kernel' instead of
> 'dso' since it might be invalid at this time.
>
> Could you please check below patch?
>
>
> From e28ec815465721b81669c47eb00d8307f4b424cd Mon Sep 17 00:00:00 2001
> From: Namhyung Kim <namhyung@kernel.org>
> Date: Mon, 10 Nov 2014 15:05:26 +0900
> Subject: [PATCH] perf tools: Fix segfault due to invalid kernel dso access
>
> When processing kernel mmap event, it should access the 'kernel'
> variable as sometimes it cannot find a matching dso from build-id
> table so 'dso' might be invalid.
>
> Reported-by: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

yep, works nicely now

Tested-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka


\
 
 \ /
  Last update: 2014-11-10 16:41    [W:0.032 / U:1.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site