Messages in this thread | | | Date | Mon, 10 Nov 2014 15:44:41 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v2 1/2] i2c: add support for Amlogic Meson I2C controller |
| |
On Sun, Oct 05, 2014 at 10:17:11PM +0200, Beniamino Galvani wrote: > This is a driver for the I2C controller found in Amlogic Meson SoCs. > > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
Thanks. Looking very good already!
> +static void meson_i2c_prepare_xfer(struct meson_i2c *i2c, bool write)
Instead of the bool, maybe you could query i2c->state in the function? You decide, I am not forcing you to do this.
> +static u32 meson_i2c_func(struct i2c_adapter *adap) > +{ > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > +}
Have you tested 0-byte transfers, too (i2cdetect -q)? What was your test scenario in general?
Just minor questions. It is good to go already!
[unhandled content-type:application/pgp-signature] | |