Messages in this thread | | | Date | Mon, 10 Nov 2014 21:47:27 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v4 4/6] hw_random: fix unregister race. |
| |
On Mon, Nov 03, 2014 at 11:56:24PM +0800, Amos Kong wrote: > > @@ -98,6 +99,8 @@ static inline void cleanup_rng(struct kref *kref) > > if (rng->cleanup) > rng->cleanup(rng);
You need a compiler barrier here to prevent reordering.
> + rng->cleanup_done = true;
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |