lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] i2c/at91: adopt pinctrl support
Hello.

On 11/10/2014 4:55 AM, Wenyou Yang wrote:

> Amend the at91 i2c pin controller

You're amending the hardware itself, really? :-)

> to optionally take a pin controlhandle

I don't see the code that does this.

> and set the state of the pins to:
> - "default" on boot and resume.

I don't see where you are changing anything for the probe() method.
Perhaps you meant the driver core code which selects the dafault profile
automatically?

> - "sleep" on suspend().

> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle

> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> Hi Wolfram,
>
> Thanks a lot.
>
> The change of this version is to remove
> pinctrl_pm_select_default_state(&pdev->dev) from the _probe function.

Aha, you've specifically removed this...

WBR, Sergei



\
 
 \ /
  Last update: 2014-11-10 12:41    [W:0.192 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site