lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [Xen-devel] [PATCH] xen/arm: Return correct code error for xen_swiotlb_map_page
Date
> On Thu, Nov 06, 2014 at 07:14:51PM +0000, Stefano Stabellini wrote:
> > On Thu, 6 Nov 2014, Frediano Ziglio wrote:
> > > 2014-11-06 17:30 GMT+00:00 Stefano Stabellini
> <stefano.stabellini@eu.citrix.com>:
> > > On Thu, 6 Nov 2014, Frediano Ziglio wrote:
> > > > On ARM error code is not 0 so avoid to return it as error.
> > > >
> > > > Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
> > >
> > > Acked-by: Stefano Stabellini
> > > <stefano.stabellini@eu.citrix.com>
> > >
> > >
> > > Could you please fix the same error in lib/swiotlb.c too
> please?
> > >
> > >
> > > Same patch or another ?
> > >
> >
> > Another
>
> It might break the build. Please double-check that it does not affect
> ia64.
> >

Code in lin/swiotlb.c does not require any changes as the error value is completely different here (is the pa address of a static allocated buffer). On ia64 the constant I used in my previous patch is 0 so it produce the same assembly code.

Frediano

> > >
> > > >  drivers/xen/swiotlb-xen.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/xen/swiotlb-xen.c
> b/drivers/xen/swiotlb-xen.c
> > > > index ebd8f21..3b8d628 100644
> > > > --- a/drivers/xen/swiotlb-xen.c
> > > > +++ b/drivers/xen/swiotlb-xen.c
> > > > @@ -425,7 +425,7 @@ dma_addr_t xen_swiotlb_map_page(struct
> device *dev, struct page *page,
> > > >        */
> > > >       if (!dma_capable(dev, dev_addr, size)) {
> > > >               swiotlb_tbl_unmap_single(dev, map, size, dir);
> > > > -             dev_addr = 0;
> > > > +             dev_addr = DMA_ERROR_CODE;
>
> That looks Ok to me.
>
> > > >       }
> > > >       return dev_addr;
> > > >  }
> > > > --
> > > > 1.9.1
> > > >
> > > >
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> > > > the body of a message to majordomo@vger.kernel.org
> > > > More majordomo info at  http://vger.kernel.org/majordomo-
> info.html
> > > > Please read the FAQ at http://secure-
> web.cisco.com/1cvjROyUxV6SnA0uBTMRubqrQWsaXGhps-
> FWjY3vly9AxaKKlt2DPY7GjL0FCHeP4rsbjKsc-P4zH2_7-kpcxwEH-udGrGCCq
> > > kCLlH1-fLOo1X6Nlui6EwEVHUpB2r7gt-
> Gsgxbep9QWPnIdypDPNf8Hf5clxCMXYcvWsOK5s3qg/http%3A%2F%2Fwww.tux.org%2Fl
> kml%2F
> > > >
> > >
> > > _______________________________________________
> > > Xen-devel mailing list
> > > Xen-devel@lists.xen.org
> > > http://lists.xen.org/xen-devel
> > >
> > >
> > >
> > >
>
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-11-10 11:01    [W:0.072 / U:4.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site