lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5 3/7] dw-hdmi: make checkpatch happy
Hi Andy,

In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c

Have these errors come during the previous 2 patches.

If yes, then these changes need to be squashed into the previous
patches. No patch should add a checkpatch error and then fix it in a later patch.

Regards
ZubairLK

On 08/11/14 05:29, Andy Yan wrote:
> CHECK: Alignment should match open parenthesis
> + if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
> + (hdmi->vic == 12) || (hdmi->vic == 13) ||
>
> CHECK: braces {} should be used on all arms of this statement
> + if (hdmi->hdmi_data.video_mode.mdvi)
> [...]
> + else {
> [...]
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 97 ++++++++++++++++++++--------------------
> 1 file changed, 48 insertions(+), 49 deletions(-)


\
 
 \ /
  Last update: 2014-11-10 11:01    [W:0.086 / U:4.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site