lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again.
On Sat, 08 Nov 2014, NeilBrown wrote:
>
> commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> mfd: twl4030-power: Add generic reset configuration
>
> claims:
> Let's add device tree support and configure things for warm reset
> as the default when compatible = "ti,twl4030-power".
> and
> Documentation/devicetree/bindings/mfd/twl4030-power.txt
> claims that "ti,twl4030-power" is still a valid "compatible" setting.
>
> However the current driver fails to probe with that 'compatible'
> setting.
> Restore the old default.
>
> Signed-off-by: NeilBrown <neilb@suse.de>

Tony should take a look at this.

> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 4d3ff3771491..1a7794f6be15 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
>
> static struct of_device_id twl4030_power_of_match[] = {
> {
> + .compatible = "ti,twl4030-power",
> + .data = NULL,
> + },
> + {
> .compatible = "ti,twl4030-power-reset",
> .data = &omap3_reset,
> },



--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-11-10 10:41    [W:0.071 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site