lkml.org 
[lkml]   [2014]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86, cpu: trivial printk formatting fixes
From
Date
(Adding Len Brown, original post: https://lkml.org/lkml/2014/11/1/67)

On Sat, 2014-11-01 at 17:38 +0000, Steven Honeyman wrote:
> On 1 November 2014 17:17, Joe Perches <joe@perches.com> wrote:
> > This changes the logging level.
> >
> > You should either mention why in the changelog
> > or use pr_warn_once
>
> OK, I will resubmit with a new description if needed.
> Would you agree that info is a more suitable log level than warn for
> this message? Even notice seemed too much, as it isn't a 'significant
> condition'

This is only emitted when the bios didn't do the "right thing".
See commit abe48b108247e9b90

So it seems more like the origial message isn't descriptive
enough than KERN_WARN is not the correct level.




\
 
 \ /
  Last update: 2014-11-01 19:21    [W:0.048 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site