lkml.org 
[lkml]   [2014]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog
On Wed, 08 Oct 2014, Guenter Roeck wrote:

> On Wed, Oct 08, 2014 at 10:33:30AM +0100, Lee Jones wrote:
> > Signed-off-by: David Paris <david.paris@st.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/watchdog/Kconfig | 16 +++
> > drivers/watchdog/Makefile | 1 +
> > drivers/watchdog/st_wdt.c | 317 ++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 334 insertions(+)
> > create mode 100644 drivers/watchdog/st_wdt.c
> >
>
> Unfortunately (built with W=1):
>
> drivers/watchdog/st_wdt.c: In function 'st_wdog_load_timer':
> drivers/watchdog/st_wdt.c:114:14: warning: comparison between signed and
> unsigned integer expressions [-Wsign-compare]
> drivers/watchdog/st_wdt.c: In function 'st_wdog_remove':
> drivers/watchdog/st_wdt.c:273:24: error: 'clk' undeclared (first use in this
> function)
>
> and checkpatch complains a bit:
>
> WARNING: please, no space before tabs
> #303: FILE: drivers/watchdog/st_wdt.c:236:
> +^Ist_wdog->dev ^I^I= &pdev->dev;$
>
> WARNING: please, no space before tabs
> #304: FILE: drivers/watchdog/st_wdt.c:237:
> +^Ist_wdog->base ^I^I= base;$
>
> WARNING: please, no space before tabs
> #306: FILE: drivers/watchdog/st_wdt.c:239:
> +^Ist_wdog->warm_reset ^I= of_property_read_bool(np, "st,warm_reset");$

Thanks for taking the time to build this Guenter. I must profess, the
recent submissions were delivered hastily, due to other pressing tasks
and a mountain of email to peruse. The next submission will be
subject extensive; build, static analysis and execution testing.
Sorry to waste your time.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-10-09 10:02    [W:2.192 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site