Messages in this thread | | | Date | Wed, 8 Oct 2014 10:53:52 -0700 | From | David Cohen <> | Subject | Re: [PATCH] usb: ffs: fix regression when quirk_ep_out_aligned_size flag is set |
| |
On Tue, Oct 07, 2014 at 07:31:44PM -0500, Felipe Balbi wrote: > Hi,
Hi Felipe,
> > On Tue, Oct 07, 2014 at 05:18:06PM -0700, David Cohen wrote: > > The commit '2e4c7553cd usb: gadget: f_fs: add aio support' broke the > > did that commit non-aio or is only aio broken ?
That commit broke the quirk on both cases.
> > > quirk implemented to align buffer size to maxpacketsize on out endpoint. > > As result, functionfs does not work on Intel platforms using dwc3 driver > > (i.e. Bay Trail and Merrifield). This patch fixes the issue. > > and Braswell. > > > This code is based on a previous Qiuxu's patch. > > How have you tested this ? Do you have a test-case to share ? Then I can > add it to my tests which I have been running on my platforms too (they > include USB20CV and USB30CV where applicable - quite a few fixes coming > soon).
My testcase is to use Android's adbd service via function_fs (no out-of-tree android gadget). Without the quitk, it doesn't work.
Br, David
> > cheers > > -- > balbi
| |