Messages in this thread | | | Date | Tue, 7 Oct 2014 21:43:10 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 08/11] perf/x86/intel: Add Intel Cache QoS Monitoring support |
| |
On Wed, Sep 24, 2014 at 03:04:12PM +0100, Matt Fleming wrote: > +/* > + * Determine if @a and @b measure the same set of tasks. > + */ > +static bool __match_event(struct perf_event *a, struct perf_event *b) > +{ > + if ((a->attach_state & PERF_ATTACH_TASK) != > + (b->attach_state & PERF_ATTACH_TASK)) > + return false; > + > + /* not task */ > + > + return true; /* if not task, we're machine wide */ > +}
You cut too much out there. That first test checks weather the two events are of the same type; ie. both tasks or both cpu. After that you still need to verify that they are indeed the same target.
| |