Messages in this thread | | | Date | Tue, 7 Oct 2014 08:57:13 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 07/44] qnap-poweroff: Drop reference to pm_power_off from devicetree bindings |
| |
On Tue, Oct 07, 2014 at 12:02:19PM +0100, Mark Rutland wrote: > On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote: > > Replace reference to pm_power_off (which is an implementation detail) > > and replace it with a more generic description of the driver's functionality. > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Pawel Moll <pawel.moll@arm.com> > > Cc: Mark Rutland <mark.rutland@arm.com> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > --- > > Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > index af25e77..1e2260a 100644 > > --- a/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > +++ b/Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt > > @@ -3,8 +3,8 @@ > > QNAP NAS devices have a microcontroller controlling the main power > > supply. This microcontroller is connected to UART1 of the Kirkwood and > > Orion5x SoCs. Sending the character 'A', at 19200 baud, tells the > > -microcontroller to turn the power off. This driver adds a handler to > > -pm_power_off which is called to turn the power off. > > +microcontroller to turn the power off. This driver installs a handler > > +to power off the system. > > I'd remove the last sentence -- the driver is also independent of the > HW, and the description of how the power off works at the HW level is > sufficient. > Done.
> With that: > > Acked-by: Mark Rutland <mark.rutland@arm.com> > Thanks!
Guenter
| |