lkml.org 
[lkml]   [2014]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 01/15] virtio_pci: fix virtio spec compliance on restore
On Tue, Oct 07, 2014 at 05:35:13PM +0530, Amit Shah wrote:
> On (Mon) 06 Oct 2014 [18:10:40], Michael S. Tsirkin wrote:
> > On restore, virtio pci does the following:
> > + set features
> > + init vqs etc - device can be used at this point!
> > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits
> >
> > This is in violation of the virtio spec, which
> > requires the following order:
> > - ACKNOWLEDGE
> > - DRIVER
> > - init vqs
> > - DRIVER_OK
> >
> > This behaviour will break with hypervisors that assume spec compliant
> > behaviour. It seems like a good idea to have this patch applied to
> > stable branches to reduce the support butden for the hypervisors.
> >
> > Cc: stable@vger.kernel.org
> > Cc: Amit Shah <amit.shah@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> I didn't see my previous questions answered from the initial posting
> -- can you please respond to them?
>
> Amit

Ooops missed your mail.
Will respond now.



\
 
 \ /
  Last update: 2014-10-07 15:21    [W:1.587 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site