lkml.org 
[lkml]   [2014]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/27] mfd: ab8500-gpadc: use pm_runtime_last_busy_and_autosuspend helper
On Tue, Oct 07, 2014 at 08:21:25AM +0100, Lee Jones wrote:
> On Mon, 06 Oct 2014, Lee Jones wrote:
>
> > On Wed, 24 Sep 2014, Vinod Koul wrote:
> >
> > > Use the new pm_runtime_last_busy_and_autosuspend helper instead of open
> > > coding the same code
> > >
> > > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > > ---
> > > drivers/mfd/ab8500-gpadc.c | 6 ++----
> > > 1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > Applied with Linus' Ack.
>
> Okay, I just had to search online for the other patches (as you left
> me off PATCH 00/27). It appears this approach has gone down like a
> lead balloon. For this reason I'm pulling these patches from my v3.19
> branch.
I was about to reply to you to revert.
I need to fix the script I used to do CC on 0th patch, looks like few
people were left off while collecting the names. Sorry about that

--
~Vinod

>
> > > diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> > > index 36000f9..46bea3a 100644
> > > --- a/drivers/mfd/ab8500-gpadc.c
> > > +++ b/drivers/mfd/ab8500-gpadc.c
> > > @@ -571,8 +571,7 @@ int ab8500_gpadc_double_read_raw(struct ab8500_gpadc *gpadc, u8 channel,
> > > }
> > >
> > > /* Disable VTVout LDO this is required for GPADC */
> > > - pm_runtime_mark_last_busy(gpadc->dev);
> > > - pm_runtime_put_autosuspend(gpadc->dev);
> > > + pm_runtime_last_busy_and_autosuspend(gpadc->dev);
> > >
> > > mutex_unlock(&gpadc->ab8500_gpadc_lock);
> > >
> > > @@ -910,8 +909,7 @@ static int ab8500_gpadc_resume(struct device *dev)
> > > if (ret)
> > > dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret);
> > >
> > > - pm_runtime_mark_last_busy(gpadc->dev);
> > > - pm_runtime_put_autosuspend(gpadc->dev);
> > > + pm_runtime_last_busy_and_autosuspend(gpadc->dev);
> > >
> > > mutex_unlock(&gpadc->ab8500_gpadc_lock);
> > > return ret;
> >
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-10-07 10:41    [W:0.260 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site