Messages in this thread | | | Date | Sun, 5 Oct 2014 15:21:19 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v2 1/2] workqueue: add quiescent state between work items |
| |
On Sun, Oct 05, 2014 at 01:24:21PM -0400, Joe Lawrence wrote: > Similar to the stop_machine deadlock scenario on !PREEMPT kernels > addressed in b22ce2785d97 "workqueue: cond_resched() after processing > each work item", kworker threads requeueing back-to-back with zero jiffy > delay can stall RCU. The cond_resched call introduced in that fix will > yield only iff there are other higher priority tasks to run, so force a > quiescent RCU state between work items. > > Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com> > Link: https://lkml.kernel.org/r/20140926105227.01325697@jlaw-desktop.mno.stratus.com > Link: https://lkml.kernel.org/r/20140929115445.40221d8e@jlaw-desktop.mno.stratus.com > Fixes: b22ce2785d97 ("workqueue: cond_resched() after processing each work item") > Cc: <stable@vger.kernel.org>
Applied to wq/for-3.17-fixes. If 3.17 comes out before this gets merged, I'll send it as for-3.18.
Thanks.
-- tejun
| |