lkml.org 
[lkml]   [2014]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v8 1/5] PM / Runtime: Add getter for querying the IRQ safe option
    From
    Date
    On pon, 2014-10-20 at 11:04 +0200, Krzysztof Kozlowski wrote:
    > Add a simple getter pm_runtime_is_irq_safe() for querying whether runtime
    > PM IRQ safe was set or not.
    >
    > Various bus drivers implementing runtime PM may use choose to suspend
    > differently based on IRQ safeness status of child driver (e.g. do not
    > unprepare the clock if IRQ safe is not set).
    >
    > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

    Rafael, Len, Pavel,

    Is proposed API ok? Do you have any comments?

    I'll upload whole patchset to Russell's patch tracking system. However
    an ack from PM maintainer is probably needed.

    Best regards,
    Krzysztof


    > ---
    > Documentation/power/runtime_pm.txt | 4 ++++
    > include/linux/pm_runtime.h | 6 ++++++
    > 2 files changed, 10 insertions(+)
    >
    > diff --git a/Documentation/power/runtime_pm.txt b/Documentation/power/runtime_pm.txt
    > index f32ce5419573..397b81593142 100644
    > --- a/Documentation/power/runtime_pm.txt
    > +++ b/Documentation/power/runtime_pm.txt
    > @@ -468,6 +468,10 @@ drivers/base/power/runtime.c and include/linux/pm_runtime.h:
    > - set the power.irq_safe flag for the device, causing the runtime-PM
    > callbacks to be invoked with interrupts off
    >
    > + bool pm_runtime_is_irq_safe(struct device *dev);
    > + - return true if power.irq_safe flag was set for the device, causing
    > + the runtime-PM callbacks to be invoked with interrupts off
    > +
    > void pm_runtime_mark_last_busy(struct device *dev);
    > - set the power.last_busy field to the current time
    >
    > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
    > index 367f49b9a1c9..44d74f0f182e 100644
    > --- a/include/linux/pm_runtime.h
    > +++ b/include/linux/pm_runtime.h
    > @@ -128,6 +128,11 @@ static inline void pm_runtime_mark_last_busy(struct device *dev)
    > ACCESS_ONCE(dev->power.last_busy) = jiffies;
    > }
    >
    > +static inline bool pm_runtime_is_irq_safe(struct device *dev)
    > +{
    > + return dev->power.irq_safe;
    > +}
    > +
    > #else /* !CONFIG_PM_RUNTIME */
    >
    > static inline int __pm_runtime_idle(struct device *dev, int rpmflags)
    > @@ -167,6 +172,7 @@ static inline bool pm_runtime_enabled(struct device *dev) { return false; }
    >
    > static inline void pm_runtime_no_callbacks(struct device *dev) {}
    > static inline void pm_runtime_irq_safe(struct device *dev) {}
    > +static inline bool pm_runtime_is_irq_safe(struct device *dev) { return false; }
    >
    > static inline bool pm_runtime_callbacks_present(struct device *dev) { return false; }
    > static inline void pm_runtime_mark_last_busy(struct device *dev) {}



    \
     
     \ /
      Last update: 2014-10-31 10:21    [W:2.651 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site