Messages in this thread | | | From | Eric Rannaud <> | Date | Thu, 30 Oct 2014 19:12:32 -0700 | Subject | Re: [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0 |
| |
On Thu, Oct 30, 2014 at 6:04 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Thu, Oct 30, 2014 at 5:57 PM, Eric Rannaud <e@nanocritical.com> wrote: >> Yes, there definitely is a glibc bug: a fix is being worked on and it >> looks like it will go in. The change replaces the test for O_CREAT by >> a test for either O_CREAT or O_TMPFILE. > > Why not just do it unconditionally? There really is no downside. Doing > it conditionally only makes the generated code slower and mode > complex. For absolutely zero gain, as far as I can tell. Does any > architecture actually do anything wrong?
The immediate answer is "to keep the diff minimal". But I'll ask.
-- Eric Rannaud <e@nanocritical.com> Nanocritical, CEO
| |