lkml.org 
[lkml]   [2014]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kbuild: collect shorthands into the top Makefile
Hi Sam,

On Wed, 29 Oct 2014 19:59:07 +0100
Sam Ravnborg <sam@ravnborg.org> wrote:

> On Wed, Oct 29, 2014 at 04:27:31PM +0900, Masahiro Yamada wrote:
> > The motivation of this commit is to avoid duplicated definitions
> > of "clean" and "hdr-inst" shorthands.
> >
> > The shorthand "clean" is defined in both the top Makefile and
> > scripts/Makefile.clean.
> >
> > Likewise, "hdr-inst" is defined in both the top Makefile and
> > scripts/Makefile.headersinst.
> >
> > The idea here is define and export them in the top Makefile
> > because $(srctree) is constant during the build process.
> >
> > For consistency, "build" and "modbuiltin" should be also moved.
>
> As a general rule the exported names are always UPPERCASE, and local variables
> are lowercase. (srctree, objtree are the exceptions).
> This patch define new lowercase variables that conflicts with this.
>
> And it is not that logical these are picked up from the enviroment.
> Could you find a central place to define them rahter than using
> the environemnt to export them?

Maybe we can collect them into scripts/Kbuild.include
although it might be too much for Makefile.clean to include
the whole things in Kbuild.include.


Best Regards
Masahiro Yamada



\
 
 \ /
  Last update: 2014-10-31 03:41    [W:0.081 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site