Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] serial: of-serial: zero-out struct of_serial_info | Date | Thu, 30 Oct 2014 22:55 +0100 |
| |
On Thursday 30 October 2014 14:18:33 Florian Fainelli wrote: > of_platform_serial_probe() invokes of_platform_serial_setup() with a > kmalloc'd struct of_serial_info cookie, which is not much of a problem > for most of the struct of_serial_info fields we access but info->clk. > > On platforms which do not provide a clock phandle for their UART nodes > but do provide a 'clock-frequency' property, we basically leave the > info->clk variable uninitialized, and this craps out during > suspend/resume with oopses, crashes or warnings in the clock code. > > Fix this by using kzalloc() which also zeroes-out the structure and > provides an initialized info->clk member set to NULL. > > Fixes: 2dea53bf57783 ("serial: of-serial: add PM suspend/resume support") > Fixes: e34b9c94b6e8d ("[POWERPC] of_serial: add port type checking") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >
I thought I'd acked this patch before, maybe someone else sent the same one. This is definitely required, so
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |