Messages in this thread | | | Date | Thu, 30 Oct 2014 11:43:00 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors |
| |
On Thu, 30 Oct 2014, Arnd Bergmann wrote:
> On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote: > > Defining these macros way down in arch/sh/.../irq.c doesn't cause > > kernel/irq/generic-chip.c to use them. As far as I can tell this code > > has no effect. > > > > Signed-off-by: Kevin Cernekee <cernekee@gmail.com> > > Actually it overrides the 32-bit accessors with 16-bit accessors, > which does seem intentional and certainly has an effect.
Not really. Neither arch/sh/boards/mach-se/7343/irq.c nor arch/sh/boards/mach-se/7722/irq.c actually use irq_reg_readl/writel. They simply define it.
Thanks,
tglx
| |