lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16 335/357] md/raid1: fix_read_error should act on all non-faulty devices.
    Date
    3.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: NeilBrown <neilb@suse.de>

    commit b8cb6b4c121e1bf1963c16ed69e7adcb1bc301cd upstream.

    If a devices is being recovered it is not InSync and is not Faulty.

    If a read error is experienced on that device, fix_read_error()
    will be called, but it ignores non-InSync devices. So it will
    neither fix the error nor fail the device.

    It is incorrect that fix_read_error() ignores non-InSync devices.
    It should only ignore Faulty devices. So fix it.

    This became a bug when we allowed reading from a device that was being
    recovered. It is suitable for any subsequent -stable kernel.

    Fixes: da8840a747c0dbf49506ec906757a6b87b9741e9
    Reported-by: Alexander Lyakas <alex.bolshoy@gmail.com>
    Tested-by: Alexander Lyakas <alex.bolshoy@gmail.com>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/raid1.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/md/raid1.c
    +++ b/drivers/md/raid1.c
    @@ -2154,7 +2154,7 @@ static void fix_read_error(struct r1conf
    d--;
    rdev = conf->mirrors[d].rdev;
    if (rdev &&
    - test_bit(In_sync, &rdev->flags))
    + !test_bit(Faulty, &rdev->flags))
    r1_sync_page_io(rdev, sect, s,
    conf->tmppage, WRITE);
    }
    @@ -2166,7 +2166,7 @@ static void fix_read_error(struct r1conf
    d--;
    rdev = conf->mirrors[d].rdev;
    if (rdev &&
    - test_bit(In_sync, &rdev->flags)) {
    + !test_bit(Faulty, &rdev->flags)) {
    if (r1_sync_page_io(rdev, sect, s,
    conf->tmppage, READ)) {
    atomic_add(s, &rdev->corrected_errors);



    \
     
     \ /
      Last update: 2014-10-04 02:01    [W:2.817 / U:0.720 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site