Messages in this thread | | | Date | Wed, 29 Oct 2014 19:42:15 -0400 | From | Steven Rostedt <> | Subject | Re: [RFA][PATCH 1/8] seq_file: Rename seq_overflow() to seq_has_overflowed() and make public |
| |
On Wed, 29 Oct 2014 15:08:36 -0700 Joe Perches <joe@perches.com> wrote:
> On Wed, 2014-10-29 at 17:56 -0400, Steven Rostedt wrote: > > +A true return from seq_has_overflowed means that the seq_file buffer is full > > +and further output will be discarded. > > Perhaps the description is a bit unclear here. > > Doesn't a return of true to seq_has_overflowed mean that > more characters have already been written than the buffer > can accept? >
Actually, right now the comment is correct and the name is misleading. But I have a patch that will make the comment incorrect (and will be fixed) and the name correct.
But since seq_has_overflowed() is to be used throughout the kernel, I didn't want to have to go do patches all over again for a temporary misnomer.
In other words, I'm going to change the function to really return only if it did overflow and not just be full. But that's another patch set to come.
I can update the change log and comment to state what will happen in the future.
Thanks,
-- Steve
| |