Messages in this thread | | | Date | Tue, 28 Oct 2014 08:03:31 +0100 | From | Mike Looijmans <> | Subject | Re: [PATCH v4] Add LTC2941/LTC2943 Battery Gauge Driver |
| |
On 10/27/2014 05:38 PM, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 23, 2014 at 02:38:38PM +0200, Mike Looijmans wrote: >> Both the LTC2941 and LTC2943 measure battery capacity. >> The LTC2943 is compatible with the LTC2941, it adds voltage and >> temperature monitoring, and uses a slightly different conversion >> formula for the charge counter. >> >> To avoid confusion with e.g. the LTC2945, the driver is called >> LTC2941 instead of LTC294X. >> >> v2: Fix units of measurement: uV, uA and centidegrees. >> v3: Correctly set configuration register. Allow negative values >> for the sense resistor. >> v4: Run checkpatch.pl and fix all errors and warnings. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> --- >> [...] >> >> + np = of_node_get(client->dev.of_node); >> + >> + /* r_sense can be negative, when sense+ is connected to the battery >> + * instead of the sense-. This results in reversed measurements. */ >> + ret = of_property_read_u32(np, "resistor-sense", &r_sense); >> + if (ret < 0) { >> + dev_err(&client->dev, >> + "Could not find resistor-sense in devicetree\n"); >> + goto fail_name; >> + } >> + info->r_sense = r_sense; >> + >> + ret = of_property_read_u32(np, "prescaler-exponent", &prescaler_exp); >> + if (ret < 0) { >> + dev_err(&client->dev, >> + "PrescalerExponent not in devicetree, assume max\n"); >> + prescaler_exp = LTC2941_MAX_PRESCALER_EXP; >> + } > > The device tree properties are not documented. Please document them > in a separate patch and Cc devicetree binding maintainers. > > Apart from that the properties should be vendor prefixed (e.g. > "lltc,resistor-sense").
Thanks for your feedback. I will post the requested changes asap.
Met vriendelijke groet / kind regards,
Mike Looijmans System Expert
TOPIC Embedded Systems Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: (+31) (0) 499 33 69 79 Telefax: (+31) (0) 499 33 69 70 E-mail: mike.looijmans@topic.nl Website: www.topic.nl
Please consider the environment before printing this e-mail
Topic zoekt gedreven (embedded) software specialisten! http://topic.nl/vacatures/topic-zoekt-software-engineers/
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |