lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/11] wm8350-core: Fix probable mask then right shift defect
    Date
    Precedence of & and >> is not the same and is not left to right.
    shift has higher precedence and should be done after the mask.

    Add parentheses around the mask.

    Signed-off-by: Joe Perches <joe@perches.com>
    ---
    drivers/mfd/wm8350-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
    index 4ab527f..f5124a8 100644
    --- a/drivers/mfd/wm8350-core.c
    +++ b/drivers/mfd/wm8350-core.c
    @@ -308,7 +308,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,
    goto err;
    }

    - mode = id2 & WM8350_CONF_STS_MASK >> 10;
    + mode = (id2 & WM8350_CONF_STS_MASK) >> 10;
    cust_id = id2 & WM8350_CUST_ID_MASK;
    chip_rev = (id2 & WM8350_CHIP_REV_MASK) >> 12;
    dev_info(wm8350->dev,
    --
    2.1.2


    \
     
     \ /
      Last update: 2014-10-27 07:03    [W:2.887 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site