Messages in this thread | | | Date | Fri, 24 Oct 2014 10:03:20 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 02/16] perf pmu: Let pmu's with no events show up on perf list |
| |
Em Fri, Oct 24, 2014 at 09:57:02AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Oct 24, 2014 at 02:15:52PM +0900, Namhyung Kim escreveu: > > On Thu, 23 Oct 2014 13:45:10 +0300, Adrian Hunter wrote: > > > + if (pmu->selectable) { > > > + scnprintf(buf, sizeof(buf), "%s//", pmu->name); > > > + aliases[j] = strdup(buf); > > > > You need to check the return value here (and above too). > > Well spotted, fixing this up.
Oh well, this print_pmu_events() function needs some care, it starts by trying to alloc the array, if it fails, it silently returns, does that mean that there are no pmu events? Or that memory allocation failed?
Ok, will do the fixes in a separate patch...
- Arnaldo
| |