lkml.org 
[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1 linux-next] fs/affs/file.c: adding support to O_DIRECT
On Tue, 21 Oct 2014 18:28:11 +0200 Fabian Frederick <fabf@skynet.be> wrote:

> Based on ext2_direct_IO
>
> --- a/fs/affs/file.c
> +++ b/fs/affs/file.c
> @@ -12,6 +12,7 @@
> * affs regular file handling primitives
> */
>
> +#include <linux/aio.h>
> #include "affs.h"
>
> #if PAGE_SIZE < 4096
> @@ -392,6 +393,22 @@ static void affs_write_failed(struct address_space *mapping, loff_t to)
> }
> }
>
> +static ssize_t
> +affs_direct_IO(int rw, struct kiocb *iocb, struct iov_iter *iter,
> + loff_t offset)
> +{
> + struct file *file = iocb->ki_filp;
> + struct address_space *mapping = file->f_mapping;
> + struct inode *inode = mapping->host;
> + size_t count = iov_iter_count(iter);
> + ssize_t ret;
> +
> + ret = blockdev_direct_IO(rw, iocb, inode, iter, offset, affs_get_block);
> + if (ret < 0 && (rw & WRITE))
> + affs_write_failed(mapping, offset + count);
> + return ret;
> +}
> +
> static int affs_write_begin(struct file *file, struct address_space *mapping,
> loff_t pos, unsigned len, unsigned flags,
> struct page **pagep, void **fsdata)
> @@ -418,6 +435,7 @@ const struct address_space_operations affs_aops = {
> .writepage = affs_writepage,
> .write_begin = affs_write_begin,
> .write_end = generic_write_end,
> + .direct_IO = affs_direct_IO,
> .bmap = _affs_bmap
> };

Has this been runtime tested? If so, please add the results to the
changelog. Some performance numbers would be useful.



\
 
 \ /
  Last update: 2014-10-23 22:41    [W:0.364 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site