lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver
    On Tue, Oct 21, 2014 at 01:30:01PM +0100, Lee Jones wrote:
    > On Mon, 13 Oct 2014, Gyungoh Yoo wrote:
    >
    > > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
    > > ---
    > > Changes v4:
    > > Removed MODULE_VERSION()
    > > Modified license to GPLv2
    > >
    > > Changes v3:
    > > Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight'
    > > Assigned mfd_cell.of_compatible for binding device node
    > > Modified error messages
    > >
    > > Changes v2:
    > > Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452
    > > Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452
    > > Added message for exception or errors
    > >
    > > drivers/mfd/Kconfig | 12 +++++
    > > drivers/mfd/Makefile | 1 +
    > > drivers/mfd/sky81452.c | 110 +++++++++++++++++++++++++++++++++++++++++++
    > > include/linux/mfd/sky81452.h | 32 +++++++++++++
    > > 4 files changed, 155 insertions(+)
    > > create mode 100644 drivers/mfd/sky81452.c
    > > create mode 100644 include/linux/mfd/sky81452.h
    >
    > [...]
    >
    > > +++ b/include/linux/mfd/sky81452.h
    > > @@ -0,0 +1,32 @@
    > > +/*
    > > + * sky81452.h SKY81452 MFD driver
    > > + *
    > > + * Copyright 2014 Skyworks Solutions Inc.
    > > + * Author : Gyungoh Yoo <jack.yoo@skyworksinc.com>
    > > + *
    > > + * This program is free software; you can redistribute it and/or modify it
    > > + * under the terms of the GNU General Public License as published by the
    > > + * Free Software Foundation; either version 2, or (at your option) any
    > > + * later version.
    > > + *
    > > + * This program is distributed in the hope that it will be useful, but
    > > + * WITHOUT ANY WARRANTY; without even the implied warranty of
    > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
    > > + * General Public License for more details.
    > > + *
    > > + * You should have received a copy of the GNU General Public License along
    > > + * with this program; if not, see <http://www.gnu.org/licenses/>.
    > > + */
    > > +
    > > +#ifndef _SKY81452_H
    > > +#define _SKY81452_H
    > > +
    > > +#include <linux/sky81452-backlight.h>
    >
    > Shouldn't this live in linux/platform_data?

    I will change the location to linux/platform_data and resubmit it.
    Thank you your review.

    >
    > > +#include <linux/regulator/machine.h>
    > > +
    > > +struct sky81452_platform_data {
    > > + struct sky81452_bl_platform_data *bl_pdata;
    > > + struct regulator_init_data *regulator_init_data;
    > > +};
    > > +
    > > +#endif
    >
    > --
    > Lee Jones
    > Linaro STMicroelectronics Landing Team Lead
    > Linaro.org │ Open source software for ARM SoCs
    > Follow Linaro: Facebook | Twitter | Blog
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-10-23 05:41    [W:4.153 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site