lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] perf tool: add hists__init for perf diff
Em Wed, Oct 22, 2014 at 03:02:41PM -0400, kan.liang@intel.com escreveu:
> From: Kan Liang <kan.liang@intel.com>
>
> perf diff also uses hists/hist_entries, hists__init() should be called
> before creating any evsels.

Thanks, this one merits perf/urgent :-\

- Arnaldo

> Signed-off-by: Kan Liang <kan.liang@intel.com>
> ---
> tools/perf/builtin-diff.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 8c5c11c..25114c9 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -1142,6 +1142,11 @@ static int data_init(int argc, const char **argv)
>
> int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
> {
> + int ret = hists__init();
> +
> + if (ret < 0)
> + return ret;
> +
> perf_config(perf_default_config, NULL);
>
> argc = parse_options(argc, argv, options, diff_usage, 0);
> --
> 1.8.3.2


\
 
 \ /
  Last update: 2014-10-22 22:01    [W:0.046 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site