Messages in this thread | | | Date | Wed, 22 Oct 2014 16:29:33 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/1] perf tool: add hists__init for perf diff |
| |
Em Wed, Oct 22, 2014 at 03:02:41PM -0400, kan.liang@intel.com escreveu: > From: Kan Liang <kan.liang@intel.com> > > perf diff also uses hists/hist_entries, hists__init() should be called > before creating any evsels.
Thanks, this one merits perf/urgent :-\
- Arnaldo
> Signed-off-by: Kan Liang <kan.liang@intel.com> > --- > tools/perf/builtin-diff.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c > index 8c5c11c..25114c9 100644 > --- a/tools/perf/builtin-diff.c > +++ b/tools/perf/builtin-diff.c > @@ -1142,6 +1142,11 @@ static int data_init(int argc, const char **argv) > > int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused) > { > + int ret = hists__init(); > + > + if (ret < 0) > + return ret; > + > perf_config(perf_default_config, NULL); > > argc = parse_options(argc, argv, options, diff_usage, 0); > -- > 1.8.3.2
| |