lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fbcon: Fix option parsing control flow in fb_console_setup
On 09/10/14 12:48, Maarten ter Huurne wrote:
> Since strsep is used to tokenize the options string, after each option
> match the code should use "continue" to get the next token from strsep.
> This patch applies this pattern consistently.
>
> Previously, for "scrollback:" and "map:" the parse code would return
> (unconditionally: strsep ensures *options != ','), causing any
> following option to be ignored, while for "vc:" the parse code would
> go on to parse further options within the same token, which could lead
> to invalid input being accepted.
>
> Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
> Acked-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/video/console/fbcon.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)

Thanks, queued for 3.18 fixes.

Tomi


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-10-22 09:21    [W:0.040 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site