Messages in this thread | | | Date | Mon, 20 Oct 2014 10:06:08 +0200 | From | Hannes Reinecke <> | Subject | Re: [PATCH 1/6] scsi_dh: get module reference outside of device handler |
| |
On 10/20/2014 08:53 AM, Christoph Hellwig wrote: > On Mon, Oct 20, 2014 at 08:01:20AM +0200, Hannes Reinecke wrote: >> Is it guaranteed that you cannot call ->attach() for devices which >> already have a device_handler attached? >> You've skipped the case >> >> scsi_dh != sdev->scsi_dh_data->scsi_dh > > No. Just instead of an if / else it's an if with an early return in the > new code. > right. Indeed.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |