Messages in this thread | | | Date | Thu, 16 Oct 2014 10:44:12 +0200 | From | Greg KH <> | Subject | Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver |
| |
On Thu, Oct 16, 2014 at 10:15:08AM +0200, Andreas Werner wrote: > +struct eeprom_data { > + uint8_t eeprod_id;
Please use the "real" kernel types, "u8" here, and "u32" in other places you use uint32_t (those are userspace types, not kernel types, sorry.)
> +static DEVICE_ATTR(eeprod_id, S_IRUGO, show_eeprod_id, NULL); > +static DEVICE_ATTR(revision, S_IRUGO, show_revision, NULL); > +static DEVICE_ATTR(serial, S_IRUGO, show_serialnr, NULL); > +static DEVICE_ATTR(hw_name, S_IRUGO, show_hw_name, NULL); > +static DEVICE_ATTR(prod_date, S_IRUGO, show_prod_date, NULL); > +static DEVICE_ATTR(rep_date, S_IRUGO, show_rep_date, NULL);
DEVICE_ATTR_RO() please.
| |