lkml.org 
[lkml]   [2014]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v4 20/25] virtio_net: enable VQs early on restore
    virtio spec requires drivers to set DRIVER_OK before using VQs.
    This is set automatically after restore returns, virtio net violated this
    rule by using receive VQs within restore.

    To fix, call virtio_device_ready before using VQs.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    ---
    drivers/net/virtio_net.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
    index 3551417..6b6e136 100644
    --- a/drivers/net/virtio_net.c
    +++ b/drivers/net/virtio_net.c
    @@ -1912,6 +1912,8 @@ static int virtnet_restore(struct virtio_device *vdev)
    if (err)
    return err;

    + virtio_device_ready(vdev);
    +
    if (netif_running(vi->dev)) {
    for (i = 0; i < vi->curr_queue_pairs; i++)
    if (!try_fill_recv(&vi->rq[i], GFP_KERNEL))
    --
    MST



    \
     
     \ /
      Last update: 2014-10-13 10:22    [W:3.996 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site