lkml.org 
[lkml]   [2014]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] dm-log-userspace: fix memory leak on failure path in dm_ulog_tfr_init()
    Date
    If cn_add_callback() fails in dm_ulog_tfr_init(), it does not
    deallocate prealloced memory but calls cn_del_callback().
    It looks like a misprint.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
    ---
    drivers/md/dm-log-userspace-transfer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/md/dm-log-userspace-transfer.c b/drivers/md/dm-log-userspace-transfer.c
    index b428c0ae63d5..39ad9664d397 100644
    --- a/drivers/md/dm-log-userspace-transfer.c
    +++ b/drivers/md/dm-log-userspace-transfer.c
    @@ -272,7 +272,7 @@ int dm_ulog_tfr_init(void)

    r = cn_add_callback(&ulog_cn_id, "dmlogusr", cn_ulog_callback);
    if (r) {
    - cn_del_callback(&ulog_cn_id);
    + kfree(prealloced_cn_msg);
    return r;
    }

    --
    1.9.1


    \
     
     \ /
      Last update: 2014-10-01 23:21    [W:7.225 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site