Messages in this thread | | | Date | Wed, 01 Oct 2014 13:45:08 -0400 (EDT) | Subject | Re: [PATCH] net: ethernet : stmicro: fixed power suspend and resume failure in stmmac driver | From | David Miller <> |
| |
From: Hao Liang <hliang1025@gmail.com> Date: Wed, 1 Oct 2014 14:08:28 +0800
> I double-check my patch and the ->mac->xxx calls are still under the lock. > I think that lock is trying to protect priv struct and related data, so i > just remove some functions have no bearing on priv struct.
It's preventing parallel invocations of the ->mac->xxx calls.
The other instances are in device open/close, where RTNL semaphore is held, and no other code paths in the driver can be active.
You need the lock.
| |