lkml.org 
[lkml]   [2014]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] vfs: Fix possible NULL pointer dereference in inode_permission()
    On Fri, Jan 10, 2014 at 06:41:03AM +0800, Linus Torvalds wrote:
    > I think the sane short term fix is to make the kfree() of the i_security
    > member be a rcu free, and not clear the member.

    Interesting use case. ;-)

    Thanx, Paul

    > Not pretty, but should did this case..
    >
    > Linus
    >
    > On Jan 10, 2014 6:31 AM, "Al Viro" <viro@zeniv.linux.org.uk> wrote:
    > >
    > > iput() definitely can sleep (that's when actual truncation and inode
    > > freeing is done for opened-and-unlinked files - on the final iput() after
    > > close()), but that' irrelevant here - fsnotify_delete_inode() grabs
    > > a bunch of mutexes, which makes calling it from rcu callback no-go.



    \
     
     \ /
      Last update: 2014-01-10 00:21    [W:2.834 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site