Messages in this thread | | | Date | Tue, 7 Jan 2014 09:41:31 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/2] GenWQE: Fix endian issues detected by sparse |
| |
Could you also fix this Smatch warning? drivers/misc/genwqe/card_dev.c:658 do_flash_update() warn: maybe return -EFAULT instead of the bytes remaining?
Also we shouldn't be doing dev_err() on copy_to/from_user() problems. The user can trigger those and flood dmesg. It is a DoS (annoying).
regards, dan carpenter
| |