lkml.org 
[lkml]   [2014]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH v5 16/33] xen, irq: Call irq_alloc_reserved_desc_at() at first
On Mon, 6 Jan 2014, Yinghai Lu wrote:
> On Fri, Jan 3, 2014 at 9:50 AM, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
>
> >> drivers/xen/events.c | 8 ++++++--
> >> 1 file changed, 6 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> >> index 4035e83..020cd77 100644
> >> --- a/drivers/xen/events.c
> >> +++ b/drivers/xen/events.c
> >> @@ -508,8 +508,12 @@ static int __must_check xen_allocate_irq_gsi(unsigned gsi)
> >> /* Legacy IRQ descriptors are already allocated by the arch. */
> >> if (gsi < NR_IRQS_LEGACY)
> >> irq = gsi;
> >> - else
> >> - irq = irq_alloc_desc_at(gsi, -1);
> >> + else {
> >> + /* for x86, irq already get reserved for gsi */
> >> + irq = irq_alloc_reserved_desc_at(gsi, -1);
> >> + if (irq < 0)
> >> + irq = irq_alloc_desc_at(gsi, -1);
> >> + }
> >
> > This is common code. On ARM I get:
> >
> > drivers/xen/events.c: In function 'xen_allocate_irq_gsi':
> > drivers/xen/events.c:513:3: error: implicit declaration of function 'irq_alloc_reserved_desc_at' [-Werror=implicit-function-declaration]
> > irq = irq_alloc_reserved_desc_at(gsi, -1);
> > ^
> > cc1: some warnings being treated as errors
>
> It's strange.
>
> that is defined with irq_alloc_desc_at in parallel in
> include/linux/irq.h and kernel/irq/irqdesc.c.
>
> Did you try the whole tree, or just this patch?

Just this patch.
The whole tree (yinghai/for-x86-irq-3.14) builds just fine.
Thanks!

- Stefano


\
 
 \ /
  Last update: 2014-01-07 15:01    [W:0.047 / U:1.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site