lkml.org 
[lkml]   [2014]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel
    On Mon, Jan 06, 2014 at 09:07:26PM +0100, Stephen Warren wrote:
    > On 12/24/2013 06:32 AM, Peter De Schrijver wrote:
    > > Export APB DMA readl and writel. These are needed because we can't access
    > > the fuses directly on Tegra20 without potentially causing a system hang.
    >
    > This does a lot more than just export the functions; it also changes the
    > prototypes. I'm not sure why the prototype change was required/useful.
    > This needs to be mentioned in the commit description/subject, and the
    > reasoning explained too.
    >
    > > diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h
    >
    > > +#if defined(CONFIG_TEGRA20_APB_DMA)
    > > +void tegra_apb_io_init(void);
    >
    > This seems to be an internal function; why is this one publicly
    > prototyped and/or stubbed?
    >

    Ah. this might be a leftover from a previous iteration... Need to check.


    \
     
     \ /
      Last update: 2014-01-07 14:41    [W:2.993 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site