lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 131/144] s390/3270: fix allocation of tty3270_screen structure
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Martin Schwidefsky <schwidefsky@de.ibm.com>

    commit 36d9f4d3b68c7035ead3850dc85f310a579ed0eb upstream.

    The tty3270_alloc_screen function is called from tty3270_install with
    swapped arguments, the number of columns instead of rows and vice versa.
    The number of rows is typically smaller than the number of columns which
    makes the screen array too big but the individual cell arrays for the
    lines too small. Creating lines longer than the number of rows will
    clobber the memory after the end of the cell array.
    The fix is simple, call tty3270_alloc_screen with the correct argument
    order.

    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/s390/char/tty3270.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/s390/char/tty3270.c
    +++ b/drivers/s390/char/tty3270.c
    @@ -942,7 +942,7 @@ static int tty3270_install(struct tty_dr
    return rc;
    }

    - tp->screen = tty3270_alloc_screen(tp->view.cols, tp->view.rows);
    + tp->screen = tty3270_alloc_screen(tp->view.rows, tp->view.cols);
    if (IS_ERR(tp->screen)) {
    rc = PTR_ERR(tp->screen);
    raw3270_put_view(&tp->view);



    \
     
     \ /
      Last update: 2014-01-07 01:21    [W:4.254 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site