Messages in this thread | | | Date | Mon, 6 Jan 2014 11:05:20 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in rtllib_debug.h |
| |
On Sun, Jan 05, 2014 at 01:25:36PM +0100, Andreas Frembs wrote: > In rtllib_debug.h we fixed the following checkpatch error: > ERROR: Macros with complex values should be enclosed in parenthesis > > We fixed this with a do {} while (0), because otherwise the compiler complained. > > Signed-off-by: Andreas Frembs <andreas.frembs@studium.uni-erlangen.de> > Signed-off-by: Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de>
It would be better to replace these with WARN_ON(). I haven't looked but I also suspect that some of these asserts might be bogus and should be removed.
regards, dan carpenter
| |