lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 066/129] rtlwifi: pci: Fix oops on driver unload
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Larry Finger <Larry.Finger@lwfinger.net>

    commit 9278db6279e28d4d433bc8a848e10b4ece8793ed upstream.

    On Fedora systems, unloading rtl8192ce causes an oops. This patch fixes the
    problem reported at https://bugzilla.redhat.com/show_bug.cgi?id=852761.

    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/rtlwifi/pci.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/net/wireless/rtlwifi/pci.c
    +++ b/drivers/net/wireless/rtlwifi/pci.c
    @@ -734,6 +734,8 @@ static void _rtl_pci_rx_interrupt(struct
    };
    int index = rtlpci->rx_ring[rx_queue_idx].idx;

    + if (rtlpci->driver_is_goingto_unload)
    + return;
    /*RX NORMAL PKT */
    while (count--) {
    /*rx descriptor */
    @@ -1630,6 +1632,7 @@ static void rtl_pci_stop(struct ieee8021
    */
    set_hal_stop(rtlhal);

    + rtlpci->driver_is_goingto_unload = true;
    rtlpriv->cfg->ops->disable_interrupt(hw);
    cancel_work_sync(&rtlpriv->works.lps_change_work);

    @@ -1647,7 +1650,6 @@ static void rtl_pci_stop(struct ieee8021
    ppsc->rfchange_inprogress = true;
    spin_unlock_irqrestore(&rtlpriv->locks.rf_ps_lock, flags);

    - rtlpci->driver_is_goingto_unload = true;
    rtlpriv->cfg->ops->hw_disable(hw);
    /* some things are not needed if firmware not available */
    if (!rtlpriv->max_fw_size)



    \
     
     \ /
      Last update: 2014-01-07 01:01    [W:2.903 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site