lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scripts: Have make TAGS not include structure members
On Fri, 3 Jan 2014 14:24:32 +0100
mmarek <mmarek@suse.cz> wrote:


>
> The logic looks OK, but it is not completely obvious that $@ means

Hmm, it $@ is standard shell variable of "all commands". In fact, we
probably should change all the $1 to that instead. But I don't care how
we do it.

> 'etags --no-members, iff called as etags'. How about using a more
> descriptive variable like this?
>
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 58c4559..3afc479 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -219,7 +219,7 @@ exuberant()
>
> emacs()
> {
> - all_target_sources | xargs $1 -a \
> + all_target_sources | xargs $1 $no_members -a \
> --regex='/^\(ENTRY\|_GLOBAL\)(\([^)]*\)).*/\2/' \
> --regex='/^SYSCALL_DEFINE[0-9]?(\([^,)]*\).*/sys_\1/' \
> --regex='/^TRACE_EVENT(\([^,)]*\).*/trace_\1/' \
> @@ -308,12 +308,15 @@ case "$1" in
>
> "tags")
> rm -f tags
> + no_members=
> xtags ctags
> remove_structs=y
> ;;
>
> "TAGS")
> rm -f TAGS
> + # Do not index struct members when generating Emacs TAGS
> + no_members=--no-members
> xtags etags

Sure, I'll update this and send another patch.

Thanks,

-- Steve



\
 
 \ /
  Last update: 2014-01-06 21:01    [W:1.663 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site